chore: replaced anvil hardforks with alloy hardforks #10612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rimeeeeee
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
mattsse
requested changes
May 23, 2025
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
great start
looks like we also need the inverse of chain +u64 -> Option<Hardfork>?
let's do a rewrite of
impl<T: Into<BlockNumberOrTag>> From<T> for EthereumHardfork {
as regular fn here first and then we move this to the hardforks crate
mattsse
reviewed
May 26, 2025
zerosnacks
requested changes
May 26, 2025
Member
|
Lgtm! Pending final upstream changes in Thanks @Rimeeeeee! |
zerosnacks
approved these changes
May 27, 2025
mattsse
requested changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10609
removed redundant
EthereumHardforkandOptimismHardforkadded standalone fxns
spec_id_from_optimism_hardfork,spec_id_from_ethereum_hardforkandethereum_hardfork_from_block_tagfor supportadded tests to test standalone fxns